refactor(app): remove orphaned timeline header code by Astro-Han · Pull Request #675 · Astro-Han/pawwork

Astro-Han · 2026-05-16T06:07:22Z

Topology Update (2026-05-16)

Final base: dev after #674 was squash merged.
Dependency status: true stack dependency. The deleted header/controller block and the below-500 LOC claim are only review-clean after the preceding message-timeline extractions.
Review order: final PR in the retained message-timeline stack after #674.
Latest head after restack and review follow-up: 2c7ccaba4.

Summary

Removed the orphaned title/export/header controller block from MessageTimeline. The deleted code had no JSX call site in the current timeline render path, and this stacked PR brings message-timeline.tsx below the 500 LOC warning line.

Why

This continues the #601 message-flow architecture stack after #674. Before this PR, MessageTimeline still carried unused title editing, parent-title lookup, session export, and menu state code even though the rendered timeline no longer called those handlers or components. Keeping that block made future agents read a false responsibility boundary.

Canonical manifest: .github/frontend-architecture-manifest.md

Related Issue

Human Review Status

Fresh-eyes review clean after restack to dev and Gemini follow-up. No P0-P3 findings. The final 2c7ccaba4 push is a tree-identical amend of reviewed 146972006 to retrigger missing pull_request checks; no code changed after review.

Review Focus

Confirm the removed title/export/header controller has no render call site in this stack.
Confirm MessageTimeline render behavior is unchanged: jump button, ScrollView, staging, comments, and SessionTurn wiring remain intact.
Confirm stack base is correct: base is now dev after refactor(app): extract session turn changes #674 was squash merged.

Risk Notes

Behavior is intended unchanged. Main risk is accidentally deleting a dormant feature entry point; the current file had no JSX path using these handlers or state. No dependency, platform, persistence, or migration change.

Architecture Boundary

Owner lane: #601 message flow.

Base/depends on: #667 -> #669 -> #670 -> #671 -> #672 -> #674. This PR is now restacked on dev.

Touched files:

packages/app/src/pages/session/message-timeline.tsx

Architecture effect:

LOC reduced: message-timeline.tsx is below the 500 LOC warning line after this stack slice
dead owner removed

Review Follow-up

Gemini stale working-state thread fixed by removing the unused tint / workingStatus block and its imports. The thread was replied to and resolved.
Fresh-eyes review confirmed the final diff only changes message-timeline.tsx, does not duplicate previous stack changes, and leaves export/rename entry points in the sidebar/layout path.

How To Verify

Focused tests: bun test --preload ./happydom.ts src/pages/session/session-turn-changes.test.ts src/pages/session/session-timeline-staging.test.ts -> 5 pass, 0 fail
bun run typecheck -> 8 successful, 8 total
bun run lint -> pass
bun run frontend:inventory -> pass, warn-only; productionOver500 20, #601 message flow 2 over 500 after restack
Targeted #600 timeline perf: bun script/e2e-local.ts -- e2e/perf/perf-probe.spec.ts --grep "long-session-input-lag|session-timeline-recompute" -> 1 passed, 1 skipped
git diff --check origin/dev...HEAD && git diff --check -> pass
GitHub required checks on 2c7ccaba4: all passed, including perf-probe-baseline
Review threads: all resolved

Screenshots or Recordings

Not included. This PR removes unreachable controller code and has no intended visible UI or copy change, so Electron manual visual verification was not run.

Checklist

coderabbitai · 2026-05-16T06:07:28Z

Warning

Rate limit exceeded

@Astro-Han has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 12 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d4bc0187-7dee-462a-b502-c48618e2bc61

📥 Commits

Reviewing files that changed from the base of the PR and between ec854d7 and 2c7ccab.

📒 Files selected for processing (1)

packages/app/src/pages/session/message-timeline.tsx

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/message-timeline-dead-header

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request refactors the MessageTimeline component by removing orphaned logic related to session titles, headers, and exports, which helps resolve the file's size constraints as noted in the updated frontend architecture manifest. Feedback identifies that the imports for messageAgentColor and makeTimer are now also unused and should be removed to complete the cleanup.

github-actions · 2026-05-16T06:19:30Z

Perf delta summary

Comparator: pass

Profile / Scenario	interaction median	interaction worst	long task max	tbt	frame gap p95	frame gap max	jank count	cls	status
default / homepage-cold	48 -> 40 (-8)	56 -> 48 (-8)	98 -> 71 (-27)	48 -> 21 (-27)	16.8 -> 16.8 (0)	166.7 -> 166.7 (0)	4 -> 3 (-1)	0 -> 0 (0)	pass
default / long-session-input-lag	48 -> 40 (-8)	64 -> 48 (-16)	0 -> 0 (0)	0 -> 0 (0)	16.8 -> 16.7 (-0.1)	16.8 -> 16.7 (-0.1)	0 -> 0 (0)	0 -> 0 (0)	pass
default / session-streaming-long	48 -> 48 (0)	64 -> 64 (0)	0 -> 0 (0)	0 -> 0 (0)	16.8 -> 16.8 (0)	33.3 -> 33.3 (0)	0 -> 0 (0)	0 -> 0 (0)	pass
default / tool-call-expand	16 -> 16 (0)	24 -> 16 (-8)	0 -> 0 (0)	0 -> 0 (0)	16.8 -> 16.8 (0)	16.8 -> 16.8 (0)	0 -> 0 (0)	0 -> 0 (0)	pass
default / tool-default-open-heavy-bash	24 -> 24 (0)	32 -> 40 (+8)	65 -> 67 (+2)	15 -> 28 (+13)	50 -> 66.6 (+16.6)	100 -> 116.7 (+16.7)	3 -> 4 (+1)	0 -> 0 (0)	pass
default / terminal-side-panel-open	48 -> 56 (+8)	48 -> 56 (+8)	0 -> 0 (0)	0 -> 0 (0)	33.3 -> 33.4 (+0.1)	33.4 -> 50 (+16.6)	0 -> 0 (0)	0 -> 0 (0)	pass
default / session-scroll-reading	24 -> 24 (0)	24 -> 24 (0)	0 -> 0 (0)	0 -> 0 (0)	16.7 -> 16.8 (+0.1)	16.7 -> 16.8 (+0.1)	0 -> 0 (0)	0.505 -> 0.505 (0)	warn: cls
low-end / session-scroll-reading-long	64 -> 56 (-8)	64 -> 64 (0)	96 -> 75 (-21)	60 -> 34 (-26)	16.8 -> 16.8 (0)	133.2 -> 100 (-33.2)	3 -> 2 (-1)	0.011 -> 0.011 (0)	pass
low-end / session-timeline-recompute	128 -> 112 (-16)	136 -> 152 (+16)	112 -> 104 (-8)	198 -> 169 (-29)	100.1 -> 100 (-0.1)	183.3 -> 183.3 (0)	3 -> 3 (0)	0.081 -> 0.081 (0)	pass
low-end / concurrent-shimmer-extreme	0 -> 0 (0)	0 -> 0 (0)	0 -> 0 (0)	0 -> 0 (0)	16.7 -> 16.8 (+0.1)	16.8 -> 33.3 (+16.5)	0 -> 0 (0)	0 -> 0 (0)	pass

Goal: extract MessageTimeline turn-change ownership into a dedicated session-turn-changes module while preserving visible behavior and stack scope.\n\nBoundary: only touches the message timeline wiring, the new turn-change owner module, and focused tests. This does not change UI/product behavior, persistence, platform behavior, dependencies, release assets, or the downstream #675 scope.\n\nVerification: focused tests passed with bun test --preload ./happydom.ts src/pages/session/session-turn-changes.test.ts src/pages/session/session-message-comments.test.ts; bun run typecheck passed; targeted #600 timeline perf probe passed locally; git diff --check passed; GitHub required checks all passed including perf-probe-baseline.\n\nReview follow-up: Gemini blocked-copy separator threads were fixed and resolved. Fresh-eyes review found a locale separator P2, fixed in 8981175 so real locales own punctuation; the follow-up fresh-eyes review was clean with no P0-P3 findings.\n\nResidual risk: behavior is intended unchanged. Remaining risk is limited to moved undo/redo turn-change fetch and conflict-confirm retry wiring, covered by focused tests and required CI.

github-actions

Suggested priority: P2 (includes user-path files (packages/app/src/pages/session/message-timeline.tsx)).

P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.

Astro-Han added P2 Medium priority ui Design system and user interface app Application behavior and product flows tech-debt Internal cleanup and maintainability debt labels May 16, 2026

gemini-code-assist Bot reviewed May 16, 2026

View reviewed changes

Comment thread packages/app/src/pages/session/message-timeline.tsx Outdated

Astro-Han mentioned this pull request May 16, 2026

refactor(ui): extract session turn changes panel #676

Merged

11 tasks

Astro-Han mentioned this pull request May 16, 2026

refactor(ui): extract session turn diffs #677

Merged

11 tasks

Astro-Han force-pushed the codex/message-timeline-turn-changes branch from ac9bea9 to db3cbf5 Compare May 16, 2026 06:33

Astro-Han force-pushed the codex/message-timeline-dead-header branch from 0bca5d3 to aad77f6 Compare May 16, 2026 06:33

Astro-Han force-pushed the codex/message-timeline-turn-changes branch from db3cbf5 to 7a78f36 Compare May 16, 2026 13:47

refactor(app): remove orphaned timeline header code

65ce712

Astro-Han force-pushed the codex/message-timeline-dead-header branch from aad77f6 to 1469720 Compare May 16, 2026 14:10

Astro-Han changed the base branch from codex/message-timeline-turn-changes to dev May 16, 2026 14:10

fix(app): remove stale timeline working state

2c7ccab

Astro-Han force-pushed the codex/message-timeline-dead-header branch from 1469720 to 2c7ccab Compare May 16, 2026 14:18

github-actions Bot reviewed May 16, 2026

View reviewed changes

Astro-Han merged commit a58c491 into dev May 16, 2026
29 checks passed

Astro-Han deleted the codex/message-timeline-dead-header branch May 16, 2026 16:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(app): remove orphaned timeline header code#675

refactor(app): remove orphaned timeline header code#675
Astro-Han merged 2 commits into
devfrom
codex/message-timeline-dead-header

Astro-Han commented May 16, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 16, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented May 16, 2026 •

edited

Loading

Uh oh!

github-actions Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Astro-Han commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Topology Update (2026-05-16)

Summary

Why

Related Issue

Human Review Status

Review Focus

Risk Notes

Architecture Boundary

Review Follow-up

How To Verify

Screenshots or Recordings

Checklist

Uh oh!

coderabbitai Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

github-actions Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf delta summary

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Astro-Han commented May 16, 2026 •

edited

Loading

coderabbitai Bot commented May 16, 2026 •

edited

Loading

github-actions Bot commented May 16, 2026 •

edited

Loading